Repository navigation
3.x: Fix Flowable.groupBy eviction logic double decrement and hang - #6975
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #6975 +/- ##
============================================
+ Coverage 99.65% 99.66% +0.01%
- Complexity 6670 6671 +1
============================================
Files 742 742
Lines 47254 47254
Branches 6370 6371 +1
============================================
+ Hits 47090 47098 +8
+ Misses 51 47 -4
+ Partials 113 109 -4 Continue to review full report at Codecov.
|
davidmoten
approved these changes
May 10, 2020
davidmoten
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @akarnokd
vanniktech
approved these changes
May 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a group is evicted, the group is synchronously
onCompleted during anonNext. If a cancellation happened during this time (for example, when apublishcancels its upstream because its output completes), the cancellation would unconditionally decrement the group counter even though thegroupsmap had no longer the group (because it was evicted before). Then once the eviction logic finishes, it decremented the group counter again, leading to invalid internal state and hangs.The fix is to only decrement if there was a group actually removed from the map.
Fixes #6974